Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanups #48

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Misc cleanups #48

merged 3 commits into from
Dec 3, 2024

Conversation

crawfxrd
Copy link
Member

Apply some cleanups for commit ef237e7 specifically:

  • Remove unused debug feature
  • Remove unused coreboot module
  • Remove unused dependencies

And some more generally

  • Move default target and rustflags to .cargo/config.toml
  • Remove use of mtools/parted and use target directory as a drive
  • Remove startup.nsh script and document how to load the driver in QEMU
  • Remove deps.sh now that Make and Rust are the only dependencies
  • Replace use of emit with specifying the normal binary path

Signed-off-by: Tim Crawford <[email protected]>
Fixes: ef237e7 ("Remove debug logging")
Signed-off-by: Tim Crawford <[email protected]>
- Move default target and rustflags to `.cargo/config.toml`
- Remove use of mtools/parted and use target directory as a drive
- Remove `startup.nsh` script and document how to load the driver in QEMU
- Remove `deps.sh` now that Make and Rust are the only dependencies
- Replace use of `emit` with specifying the normal binary path

Signed-off-by: Tim Crawford <[email protected]>
@crawfxrd crawfxrd requested review from a team December 2, 2024 15:41
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on oryp12. Firmware-setup seems to be working fine with these changes.

@jackpot51 jackpot51 merged commit 5aea5d6 into master Dec 3, 2024
1 check passed
@jackpot51 jackpot51 deleted the cleanup branch December 3, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants